Re: [PATCH 2/6] flow, tcp_splice: Prefer 'sidei' for variables referring to side index

On Wed, Jul 17, 2024 at 07:20:17AM +0200, Stefano Brivio wrote:
...
  On Wed, 17 Jul 2024 14:52:19 +1000
 David Gibson <david(a)gibson.dropbear.id.au> wrote:
 
  @@ -164,17 +164,17 @@ struct flow_common {
  
  /**
   * struct flow_sidx - ID for one side of a specific flow
 - * @side:	Side referenced (0 or 1)
 + * @side:	Index of side referenced (0 or 1)
   * @flow:	Index of flow referenced 
 
 Nit (I can fix this up on merge, and I didn't finish reviewing yet):
 the comment to the struct should also use sidei/flowi. 
If this is the only issue, go ahead and fix on merge.  If there are
any more nits I'll make a new spin.

...
  
    */
  typedef struct flow_sidx {
 -	unsigned	side :1;
 -	unsigned	flow :FLOW_INDEX_BITS;
 +	unsigned	sidei :1;
 +	unsigned	flowi :FLOW_INDEX_BITS;
  } flow_sidx_t; 
  
-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson