Re: [PATCH 3/3] igmp: Remove apparently unneeded suppression

On Wed, Jan 14, 2026 at 12:35:03AM +0100, Stefano Brivio wrote:

On Tue, 13 Jan 2026 14:54:15 +1100 David Gibson wrote:

...

cppcheck-2.19.1 complains that the unusedFunction suppression in igmp.c doesn't match. That seems like a cppcheck bug, because the function clearly *is* unused. The function exists because otherwise the compiler fails because "ISO C forbids an empty translation unit".

mld.c contains an identical unused definition for the same reason, but without the suppression. It doesn't seem to have caused unusedFunction warnings, so maybe cppcheck counts the non-empty translation unit requirement as a "use" of the function?

No idea why, but with this patch and cppcheck 2.16.0 I'm getting:

igmp.c:16:0: style: The function 'unused' is never used. [unusedFunction] __attribute__((__unused__)) static void unused(void) { } ^

...I guess we needed one and exactly one suppression between mld.c and igmp.c, even though it's two different translation units.

Huh. Weird.

Anyway, whatever, it's too old to make sense. Upgraded to 2.19.0, no error there, I guess it should be good enough for everybody.

Works for me. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson