On Sat, 24 Sep 2022 19:08:15 +1000
David Gibson
The information we need to keep track of which ports are forwarded where is currently split across several different values and data structures in several different places. Worse, a number of those structures are incorrectly sized due to an off by one error, which could lead to buffer overruns.
Fix the sizing, and re-organize the data structures in a way that should make it less likely to repeat that mistake.
While we're there, correct a similar off-by-one mis-sizing of a number of other arrays.
Changes since v1: * Use a define for the array size, rather than a typedef to handle the bitmaps of ports
David Gibson (8): Improve types and names for port forwarding configuration Consolidate port forwarding configuration into a common structure udp: Delay initialization of UDP reversed port mapping table Don't use indirect remap functions for conf_ports() Pass entire port forwarding configuration substructure to conf_ports() Treat port numbers as unsigned Fix widespread off-by-one error dealing with port numbers icmp: Correct off by one errors dealing with number of echo request ids
Applied now. -- Stefano