On Fri, 23 Sep 2022 17:20:32 +1000 David Gibson <david(a)gibson.dropbear.id.au> wrote:Many of our tests are based around performing transfers of sample data across passt/pasta created links. The data flow here can be a bit hard to follow since, e.g. we create a file transfer it to the guest, then transfer it back to the host across several different tests. This also means that the test cases aren't independent of each other. Because we don't have the original file available at both ends in some cases, we compare them by generating md5sums at each end and comparing them, which is a bit complicated. Make a number of changes to simplify this: 1. Pre-generate the sample data files as a test asset, rather than building them on the fly during the tests proper 2. Include the sample data files in the mbuto guest image 3. Because we have good copies of the original data available in all contexts, we can now simply use 'cmp' to check if the transfer has worked, avoiding md5sum complications. 4. Similarly we can always use the original copy of the sample data on the send side of each transfer, meaning that the tests become more independent of each other. Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au> --- test/.gitignore | 1 + test/Makefile | 15 +++- test/passt.mbuto | 6 +- test/passt/tcp | 53 +++++------- test/passt/udp | 29 +++---- test/passt_in_ns/tcp | 187 +++++++++++++++++------------------------- test/passt_in_ns/udp | 93 +++++++++------------ test/pasta/tcp | 79 +++++++----------- test/pasta/udp | 43 ++++------ test/two_guests/basic | 2 +- 10 files changed, 214 insertions(+), 294 deletions(-)Uh, yes, this does clean up a lot of mess. -- Stefano