Re: [PATCH v2 1/8] iov: add some functions to manage iovec

On Thu, 15 Feb 2024 11:24:38 +1100 David Gibson wrote:

On Wed, Feb 14, 2024 at 09:56:21AM +0100, Laurent Vivier wrote:

...

[...]

+ * Author: Laurent Vivier + * + * This file also contains code originally from QEMU include/qemu/iov.h + * and licensed under the following terms: + * + * Copyright (C) 2010 Red Hat, Inc. + * + * Author(s): + * Amit Shah + * Michael Tokarev + * + * This work is licensed under the terms of the GNU GPL, version 2. See + * the COPYING file in the top-level directory. + * + * Contributions after 2012-01-13 are licensed under the terms of the + * GNU GPL, version 2 or (at your option) any later version.

The description of the provenance of the code and its authorship is useful. I don't think the second copyright notice is useful in this case, since it's also Red Hat, like the first. Likewise, I don't think the GPL invocation is useful, since we're not changing that license.

That's simply a full quote of the original terms. It's not required for any purpose, but I think it's more convenient to just quote as-is rather than editing bits outs of it. -- Stefano