On Tue, Jun 14, 2022 at 04:45:05PM +0200, Stefano Brivio wrote:On Tue, 14 Jun 2022 15:12:26 +1000 David Gibson <david(a)gibson.dropbear.id.au> wrote:Huh.. interesting. I guess the things I've looked at personally must have tended towards PREFIX. I'd assumed the GNU conventions specified that, but apparently not. Ok, let's drop this one.Makefile conventions (at least in the GNUish world) tend to control the base install directory with the variable $(PREFIX) (all caps). The passt Makefile has the same thing but in lower case $(prefix). Capitalize it to match conventions.I've been wondering about this when I first added it to the Makefile, and I couldn't really find a rationale for it. From the documentation of GNU make: http://www.gnu.org/software/make/manual/make.html#Directory-Variables http://www.gnu.org/software/make/manual/make.html#DESTDIR prefix is (conventionally) lowercase, DESTDIR is uppercase, so I'd stick to that. I guess there's just some historic reason behind it. Some Makefiles of long-standing projects use prefix, some PREFIX.By the way, the rest of the series all look good to me (and is very appreciated!).-- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson