The information we need to keep track of which ports are forwarded
where is currently split across several different values and data
structures in several different places. Worse, a number of those
structures are incorrectly sized due to an off by one error, which
could lead to buffer overruns.
Fix the sizing, and re-organize the data structures in a way that
should make it less likely to repeat that mistake.
While we're there, correct a similar off-by-one mis-sizing of a number
of other arrays.
David Gibson (8):
Improve types and names for port forwarding configuration
Consolidate port forwarding configuration into a common structure
udp: Delay initialization of UDP reversed port mapping table
Don't use indirect remap functions for conf_ports()
Pass entire port forwarding configuration substructure to conf_ports()
Treat port numbers as unsigned
Fix widespread off-by-one error dealing with port numbers
icmp: Correct off by one errors dealing with number of echo request
ids
Makefile | 2 +-
conf.c | 136 +++++++++++++++++++++++----------------------------
icmp.c | 5 +-
passt.h | 1 +
port_fwd.h | 34 +++++++++++++
tcp.c | 68 ++++++++------------------
tcp.h | 13 ++---
tcp_splice.c | 4 +-
udp.c | 59 ++++++++++------------
udp.h | 27 +++++-----
10 files changed, 168 insertions(+), 181 deletions(-)
create mode 100644 port_fwd.h
--
2.37.3