Re: [PATCH 7/7] tcp: Update tap specific header too in tcp_fill_headers[46]()

On Mon, 29 Apr 2024 17:09:33 +1000
David Gibson <david(a)gibson.dropbear.id.au> wrote:

...
  tcp_fill_headers[46]() fill most of the headers, but
the tap specific
 header (the frame length for qemu sockets) is filled in afterwards.
 Filling this as well:
   * Removes a little redundancy between the tcp_send_flag() and
     tcp_data_to_tap() path
   * Makes calculation of the correct length a little easier
   * Removes the now misleadingly named 'vnet_len' variable in
     tcp_send_flag()
 
 Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
 ---
  tcp.c | 28 ++++++++++++++--------------
  1 file changed, 14 insertions(+), 14 deletions(-)
 
 diff --git a/tcp.c b/tcp.c
 index 27c06958..01987c04 100644
 --- a/tcp.c
 +++ b/tcp.c
 @@ -1321,6 +1321,7 @@ static void tcp_fill_header(struct tcphdr *th,
   * tcp_fill_headers4() - Fill 802.3, IPv4, TCP headers in pre-cooked buffers
   * @c:		Execution context
   * @conn:	Connection pointer
 + * @taph:	TAP backend specific header 
Here and below: s/TAP/tap/. Other than the minor comments I shared the
series looks good to me (and looks like a big improvement in terms of
possible sources of confusion).

-- 
Stefano