Re: [PATCH v2 1/2] udp: Allow checksum to be disabled

On Wed, 18 Sep 2024 09:41:37 +1000 David Gibson wrote:

On Wed, Sep 18, 2024 at 01:07:00AM +0200, Stefano Brivio wrote:

...

Nits only:

On Tue, 17 Sep 2024 09:30:57 +0200 Laurent Vivier wrote:

...

We can need not to set the UDP checksum. Add a parameter to udp_update_hdr4() and udp_update_hdr6() to disable it.

Signed-off-by: Laurent Vivier ---

Notes: v2: s/UPD/UDP/

udp.c | 41 +++++++++++++++++++++++++++++++---------- 1 file changed, 31 insertions(+), 10 deletions(-)

diff --git a/udp.c b/udp.c index 2ba00c9c20a8..95151efb9c46 100644 --- a/udp.c +++ b/udp.c @@ -298,11 +298,13 @@ static void udp_splice_send(const struct ctx *c, size_t start, size_t n, * @bp: Pointer to udp_payload_t to update * @toside: Flowside for destination side * @dlen: Length of UDP payload + * @no_udp_csum: Do not set UDP checksum

The description of all the other arguments are aligned, with tabs. You could just add one tab to all the others and have them aligned.

Actually, this could simply be 'no_csum', it's obviously UDP. Same for no_tcp_csum in 2/2.

I had been going to suggest the same thing, but then I realised the current name does disambiguate it from the IPv4 header checksum.

Ah, right, never mind then. -- Stefano