On Fri, Jun 21, 2024 at 05:53:22PM +0200, Stefano
Brivio wrote:
This reverts commit
c80fa6a6bb4415ad48f9e11424310875d0d99bc7, as it
reintroduces the issue fixed by commit 1e6f92b995a9 ("udp: Fix 16-bit
overflow in udp_invert_portmap()").
Reported-by: Laurent Jacquot <jk(a)lutty.net>
Link:
https://bugs.passt.top/show_bug.cgi?id=80
Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
Argh, dammit. So,
Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>
.. but I think we really need to put a comment on this, otherwise one
of us is likely to make the same mistake again, because that
particular promotion rule is truly arcane.
Pushed with a comment (part of commit for 2/2), I hope it's clear
enough now.
--
Stefano