Re: [RFC v2 04/11] tcp: export memory regions to vhost

On Mon, Jul 28, 2025 at 06:41:20PM +0200, Eugenio Perez Martin wrote:

On Wed, Jul 23, 2025 at 9:06 AM David Gibson wrote:

...

On Wed, Jul 09, 2025 at 07:47:41PM +0200, Eugenio Pérez wrote:

...

So vhost kernel is able to access the TCP buffers.

Signed-off-by: Eugenio Pérez --- tap.c | 14 +++++++++++--- tcp_buf.c | 14 ++++---------- tcp_buf.h | 19 +++++++++++++++++++ 3 files changed, 34 insertions(+), 13 deletions(-)

diff --git a/tap.c b/tap.c index 0656294..8b3ec45 100644 --- a/tap.c +++ b/tap.c @@ -63,6 +63,8 @@ #include "vhost_user.h" #include "vu_common.h"

+#include "tcp_buf.h" +

I don't love including the pretty specific content of tcp_buf.h into the mostly protocol unaware tap.c. Though I do realise that avoiding it will probably have other tradeoffs.

I was more focused on testing the performance of the solution than making it pretty, but I'm a big fan of hiding the buffers somehow :). I just didn't explore the options.

Ok, that's fine for now then. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson