Re: [PATCH v3 2/3] tcp: leverage support of SO_PEEK_OFF socket option when available

On Tue, 14 May 2024 16:06:22 -0400
Jon Maloy <jmaloy(a)redhat.com> wrote:

...
  [...]

 
  +	}
 +	info("SO_PEEK_OFF%ssupported", peek_offset_cap ? " " : " not
");   
 Maintaining the extra newline before the return would be nice.   
There is a reason I prefer printf() when debugging ;-) 
No no, I really meant having one newline between info() and the return
0 below, to keep the separation we had before. I wasn't commenting
about the info() itself or about the format.

...
  I will add it and post a new version shortly.
 
 ///jon
 
  The
 changes actually related to SO_PEEK_OFF look good to me otherwise.
  
>   	return 0;
>   }
>      
  
-- 
Stefano