Re: [PATCH 0/9] vhost-user: Migration support

On Fri, 17 Jan 2025 14:58:31 +0100
Laurent Vivier <lvivier(a)redhat.com> wrote:

...
  On 17/01/2025 14:38, Stefano Brivio wrote:
 
  So we can
implement VHOST_USER_SEND_RARP with an empty function (at least to silence the
 "Vhost user backend fails to broadcast fake RARP" message).   
 Oh, sure,
if it's so annoying. And we can't just keep
 VHOST_USER_PROTOCOL_F_RARP off in the feature flags?   
 
 VHOST_USER_PROTOCOL_F_RARP is already off in passt.
 
 So vhost_user_migration_done() returns -ENOTSUP in QEMU.
 
 And then in vhost_user_receive():
 
          r = vhost_net_notify_migration_done(s->vhost_net, mac_addr);
 
          if ((r != 0) && (display_rarp_failure)) {
              fprintf(stderr,
                      "Vhost user backend fails to broadcast fake RARP\n");

Looks like a bug, right? If we don't support it we can't fail, I would
say.

Well, but sure, given how annoying it might get, it makes sense to work
around it regardless of whether it can be fixed.

-- 
Stefano