Re: [PATCH v2 1/5] qemu_passt: Avoid double daemonizing passt

On Thu, 16 Feb 2023 14:32:48 +0100
Michal Privoznik <mprivozn(a)redhat.com> wrote:

...
  When passt is started, it daemonizes itself by
default. There's
 no point in having our virCommand module daemonize it too.
 
 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
 ---
  src/qemu/qemu_passt.c | 1 -
  1 file changed, 1 deletion(-)
 
 diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c
 index 78830fdc26..adc69fc052 100644
 --- a/src/qemu/qemu_passt.c
 +++ b/src/qemu/qemu_passt.c
 @@ -156,7 +156,6 @@ qemuPasstStart(virDomainObj *vm,
      virCommandClearCaps(cmd);
      virCommandSetPidFile(cmd, pidfile);
      virCommandSetErrorFD(cmd, &errfd);
 -    virCommandDaemonize(cmd);
  
      virCommandAddArgList(cmd,
                           "--one-off", 
For what it's worth,

Reviewed-by: Stefano Brivio <sbrivio(a)redhat.com>

-- 
Stefano