On Fri, Oct 07, 2022 at 02:47:37AM +0200, Stefano Brivio wrote:This saves some hassle when including passt.h, as we need ETH_ALEN there. Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>Hrm. So I had the impression that passt was using the convention that it's the top level files responsibility to include all the dependencies for a header before including the header, rather than having headers include other headers they need. Was I mistaken? I'm ok with either model, they each have their advantages, but I find sticking to one or the other is generally better than a mix of both. That is, it would be helpful to me for you to clarify the policy, but for this specific patch Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>--- passt.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/passt.h b/passt.h index 48e1096..de79e7b 100644 --- a/passt.h +++ b/passt.h @@ -133,6 +133,8 @@ struct ip6_ctx { struct in6_addr dns_fwd; }; +#include <netinet/if_ether.h> + /** * struct ctx - Execution context * @mode: Operation mode, qemu/UNIX domain socket or namespace/tap-- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson