On Wed, Jul 13, 2022 at 08:04:14AM +0200, Stefano Brivio wrote:On Wed, 13 Jul 2022 12:11:24 +1000 David Gibson <david(a)gibson.dropbear.id.au> wrote:Ah, dammit, you're right. In fact OPENSUSE_IMGS is in the list in 13/15, then it's incorrectly removed in 14/15. IIRC, I took it off the download list, because I got some weird results which I thought meant that just the download patch was breaking the opensuse tests. Eventually realized I was misinterpreting the results, but forgot to put it back in the list. Didn't catch it because the downloads were so slow I never removed the images to try the build from scratch. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibsonOn Tue, Jul 12, 2022 at 02:13:07PM +0200, Stefano Brivio wrote:Oops, right, I missed that, I was confused by the fact that the image didn't exist. I guess DOWNLOAD_ASSETS (from patch 13/15) in test/Makefile should also include OPENSUSE_IMGS, that's all. Added, re-running the whole thing now.On Tue, 12 Jul 2022 18:26:37 +1000 David Gibson <david(a)gibson.dropbear.id.au> wrote:No. I fiddled around with handling the SuSE and older Ubuntu images, got bogged down in details and decided to postpone that until a later time. So I'm deliberately only handling the images which can be handled by the common script I added there for now.On Mon, Jul 11, 2022 at 11:42:09AM +0200, Stefano Brivio wrote: > On Thu, 7 Jul 2022 16:53:11 +0200 > Stefano Brivio <sbrivio(a)redhat.com> wrote: > > > [...] > > > > I'm running the tests now, let's see. :) > > For some reason qemu refuses to boot the OpenSUSE Leap 15.1 image made > this way, I haven't really looked into that yet. Huh. I ran into a bunch of problems with the OpenSUSE Leap images when I tried to do the image preparation stuff for them. But when I rolled that back and just did the image download separate, it seemed to work for me. Well... that is, it boots up and executes commands okay.Ah, wait a moment, did you perhaps forget to commit the distro/opensuse part for patch 14/15? The changes for distro/debian and distro/fedora in that patch look complete, distro/ubuntu has changes just for two versions, and distro/opensuse is not changed by that patch at all.It took me a bit to figure out because the prepared images actually work, but the test doesn't use them -- it's trying to use a temporary file that doesn't exist anymore.Um, what prepared images? AFAICT my Makefile only generates prepared images for Debian, Fedora and the newer Ubuntu cases. For SuSE and the older Ubuntu the test scripts now have qemu-img commands creating temporary images from the pre-downlaoded images (added in patch 13/15).