exeter() quoted ${__testid}, but in some places we use it there's an
extra level of shell, which needs another layer of quoting. This breaks
if testids include ';', which is quite common in exeter tests created as
a composition/pipeline of two functions. Add the required extra quoting.
While we're there, improve consistency with other scripts by always using
the optional {} around variable names.
Signed-off-by: David Gibson
---
test/lib/exeter | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/lib/exeter b/test/lib/exeter
index 0b361599..7ea084a4 100644
--- a/test/lib/exeter
+++ b/test/lib/exeter
@@ -47,9 +47,9 @@ exeter() {
[ ${CI} -eq 1 ] && video_link "${1}"
for __testid in $(${EXETOOL} list -- "${@}"); do
- __desc="$(${EXETOOL} desc -- "${@}" -- ${__testid})"
+ __desc="$(${EXETOOL} desc -- "${@}" -- "${__testid}")"
status_test_start "${__desc}"
- context_run host "${@}" "${__testid}" && status_test_ok || status_test_fail
+ context_run host "${*} '${__testid}'" && status_test_ok || status_test_fail
done
cd ..
--
2.51.0