Re: [PATCH] test/passt/ndp: Add delay in SLAAC prefix test before looking for kernel_ra address

On Tue, 26 Nov 2024 13:28:22 +1100
David Gibson <david(a)gibson.dropbear.id.au> wrote:

...
  On Mon, Nov 25, 2024 at 11:37:19AM +0100, Stefano
Brivio wrote:
  I'm not exactly sure why we need this delay,
but commit 9a0e544f05bf
 ("test: Improve test for NDP assigned prefix") broke the tests for me.
 
 I think it's because the kernel (at least all the versions I'm testing
 with) might not mark an address as 'kernel_ra' right away, so the jq
 expression doesn't return any result when we check.
 
 Fixes: 9a0e544f05bf ("test: Improve test for NDP assigned prefix")
 Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>   
 
 This will do the job, but I think we can do better.  There's logic
 above this to explicitly wait for DAD which doesn't seem to be
 working.  Having another look at it, I think that's just because the
 conditions I used are a bit sloppy.  I'm about to send a patch which
 improves them, which I hope will fix the problem you're seeing. 
Ah, right, thanks, I missed the fact that the filter on the previous
wait didn't actually match the filter for ADDR6. Your new patch fixes
the issue, so I'm discarding this one of course.

-- 
Stefano