f6d5a5239264 moved handling of -D into a later loop. However as a side effect it moved this from a switch block to an if block. I left a couple of 'break' statements that don't make sense in the new context. They should be 'continue' so that we go onto the next option, rather than leaving the loop entirely. Fixes: f6d5a5239264 ("conf: Delay handling -D option until after...") Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au> --- conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/conf.c b/conf.c index 76d37da0..ed097bdc 100644 --- a/conf.c +++ b/conf.c @@ -1682,13 +1682,13 @@ void conf(struct ctx *c, int argc, char **argv) if (dns4 - &c->ip4.dns[0] < ARRAY_SIZE(c->ip4.dns) && inet_pton(AF_INET, optarg, &dns4_tmp)) { add_dns4(c, &dns4_tmp, &dns4); - break; + continue; } if (dns6 - &c->ip6.dns[0] < ARRAY_SIZE(c->ip6.dns) && inet_pton(AF_INET6, optarg, &dns6_tmp)) { add_dns6(c, &dns6_tmp, &dns6); - break; + continue; } die("Cannot use DNS address %s", optarg); -- 2.46.0