Re: [PATCH v7] dhcp, dhcpv6: Add hostname and client fqdn ops

On Fri, Jan 10, 2025 at 10:44 AM Enrique Llorente Pastora <
ellorent(a)redhat.com&gt; wrote:

...
  On Fri, Jan 10, 2025 at 10:00 AM Stefano Brivio
&lt;sbrivio(a)redhat.com&gt;
 wrote:
 
 On Fri, 10 Jan 2025 09:39:09 +0100
 Enrique Llorente Pastora &lt;ellorent(a)redhat.com&gt; wrote:

 > On Thu, Jan 9, 2025 at 2:34 PM Stefano Brivio &lt;sbrivio(a)redhat.com&gt; 
wrote:
  > >
 > > On Thu, 9 Jan 2025 13:57:38 +0100
 > > Enrique Llorente Pastora &lt;ellorent(a)redhat.com&gt; wrote:
 > >
 > > > Also I have to move the list buffer or I will be storing it at the
 > > > first element.
 > > >  encoded_name_len = encode_domain_name(srch->list + srch->hdr.l,
 > > >                                                       NS_MAXDNAME,
 > > > 
  c->dns_search[i].n,
 
 
  >                                                  
    name_len);

 Oh, right. I didn't test this. Can't you just follow along where you
 are with 'offset'? I'm not sure, I didn't look into it. 
 I cannot use offset since it's initialize with + header

 offset += sizeof(struct opt_hdr); 
 Right, but doesn't that need to point to where we want to write anyway?
 That will be after the header, so it's good that it's past the header.
 Again, I didn't try this.
 
 Ahh right we can use offset directly

 encode_domain_name(offset, c->dns_search[i].n);
 
Correction: encode_domain_name(buf + offset, c->dns_search[i].n);


...
 
  --
 Stefano
 

 --
 Quique Llorente

 CNV networking Senior Software Engineer

 Red Hat EMEA

 ellorent(a)redhat.com

 @RedHat   Red Hat  Red Hat
 

-- 
*Quique Llorente*

CNV networking Senior Software Engineer

Red Hat EMEA <https://www.redhat.com/>

ellorent(a)redhat.com &lt;arxcruz(a)redhat.com&gt;
@RedHat <https://twitter.com/redhat>   Red Hat
<https://www.linkedin.com/company/red-hat>  Red Hat
<https://www.facebook.com/RedHatInc>
<https://www.redhat.com/>