Re: [PATCH v2 11/11] test: Use new-style command issue for passt_in_ns tests

On Fri, Sep 09, 2022 at 05:19:02PM +0200, Stefano Brivio wrote:

On Thu, 8 Sep 2022 11:49:20 +1000 David Gibson wrote:

...

Put the pieces together to use the new style context based dispatch for the passt_in_pasta tests.

Signed-off-by: David Gibson

[...]

+++ b/test/lib/setup

[...]

@@ -156,21 +147,18 @@ setup_passt_in_ns() { [ ${TRACE} -eq 1 ] && __opts="${__opts} --trace"

if [ ${VALGRIND} -eq 1 ]; then - pane_run PASST "make clean" - pane_status PASST - pane_run PASST "make valgrind" - pane_status PASST - pane_run PASST "valgrind --max-stackframe=$((4 * 1024 * 1024)) --trace-children=yes --vgdb=no --error-exitcode=1 --suppressions=test/valgrind.supp ./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,10011,10021,10031 -P passt.pid" + context_run passt "make clean" + context_run passt "make valgrind" + context_run_bg passt "valgrind --max-stackframe=$((4 * 1024 * 1024)) --trace-children=yes --vgdb=no --error-exitcode=1 --suppressions=test/valgrind.supp ./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,10011,10021,10031 -P passt.pid" else - pane_run PASST "make clean" - pane_status PASST - pane_run PASST "make" - pane_status PASST - pane_run PASST "./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,10011,10021,10031 -P passt.pid" + context_run passt "make clean" + context_run passt "make" + context_run_bg passt "./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,10011,10021,10031 -P passt.pid" fi sleep 5

- pane_run GUEST './qrap 5 qemu-system-$(uname -m)' \ + GUEST_CID=94557

While this seems to be perfectly valid: is it supposed to be random, or a specific number for a reason I'm missing...?

It's entirely arbitrary - I went with as close a visual approximation of 'passt' as I could manage with digits (which isn't very close at all). -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson