On Fri, 24 Feb 2023 11:36:51 -0800
Andrea Bolognani
On Fri, Feb 24, 2023 at 07:49:44PM +0100, Andrea Bolognani wrote:
Andrea Bolognani (5): qrap: Fix limits for PCI addresses qrap: Fix support for pc machines qrap: Drop args in JSON format qrap: Introduce machine-specific PCI address base qrap: Generate -netdev as JSON
qrap.c | 47 +++++++++++++++++++++++++++++++++++------------ 1 file changed, 35 insertions(+), 12 deletions(-)
Some information about testing.
In order to convince myself that the changes I was working on were correct, I have created a few quick and dirty test scripts. You can find them here:
https://gitlab.com/abologna/passt/-/commits/qrap-tests
The commit contains a few YAML files:
vmi-small-q35-passt.yaml # q35 VM with few devices vmi-small-pc-passt.yaml # pc VM with few devices vmi-big-q35-passt.yaml # q35 VM with many devices vmi-big-pc-passt.yaml # pc VM with many devices
Each one of those, fed into KubeVirt, results in qrap being called with a bunch of command line arguments. These are normally passed to the actual QEMU binary, but in my case I've hacked qrap so that they're simply printed out.
If you think it's useful, by the way, feel free to submit those as a patch for something on the lines of "test/kubevirt/qrap-tests", with explicit licensing terms and something similar to your email as README. We wouldn't run them automatically, I'm not sure I would personally try them out, qrap should hopefully go away in a few months (even though KubeVirt YAMLs could still be helpful), and... I know it's effort, so I'm not really pushing for it, you know better. Thanks! -- Stefano