Re: [PATCH] dhcp: Don't re-use request message for reply

On Sat, Feb 01, 2025 at 02:13:30PM +0100, Stefano Brivio wrote:

On Fri, 31 Jan 2025 15:53:29 +0100 Enrique Llorente wrote:

...

The logic composing the DHCP reply message is reusing the request message to compose the it, this kind be problematic from a security

Does "be problematic" imply "would be ... once we add longer options"?

...

context and may break the functionality.

Which one? This is important to know for distribution maintainers and, ultimately, users.

Right, as a general rule commit messages be specific and concrete about what the problem they're address is. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson