Re: [PATCH v2] util: fix confusion between offset in the iovec array and in the entry

On Wed, 20 Mar 2024 09:47:26 +0100
Laurent Vivier <lvivier(a)redhat.com> wrote:

...
  In write_remainder() 'skip' is the offset to
start the operation from
 in the iovec array.
 
 In iov_skip_bytes(), 'skip' is also the offset in the iovec array but
 'offset' is the first unskipped byte in the iovec entry.
 
 As write_remainder() uses 'skip' for both, 'skip' is reset to the
 first unskipped byte in the iovec entry rather to staying the first
 unskipped byte in the iovec array.
 
 Fix the problem by introducing a new variable not to overwrite 'skip'
 on each loop.
 
 Fixes: 8bdb0883b441 ("util: Add write_remainder() helper")
 Cc: david(a)gibson.dropbear.id.au
 Signed-off-by: Laurent Vivier <lvivier(a)redhat.com> 
Applied.

-- 
Stefano