Re: [PATCH v2 07/11] test: Add nsholder utility

On Fri, Sep 09, 2022 at 05:18:58PM +0200, Stefano Brivio wrote:
11;rgb:ffff/ffff/ffff> Nit:
...
  
 On Thu,  8 Sep 2022 11:49:16 +1000
 David Gibson <david(a)gibson.dropbear.id.au> wrote:
 
  [...]

 diff --git a/test/nsholder.c b/test/nsholder.c
 new file mode 100644
 index 0000000..bfe3611
 --- /dev/null
 +++ b/test/nsholder.c
 @@ -0,0 +1,117 @@
 +#define _GNU_SOURCE 
 
 It would be nice to have a licence and copyright notice here. From my
 perspective it's not necessarily needed (it would default to AGPLv3 and
 you as copyright holder), but might cause some trouble to packagers. 
Good point.  I added those notices and an informational banner.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson