Re: [PATCH v5 23/29] dhcpv6: use iov_tail rather than pool

On Thu, 17 Apr 2025 18:51:30 +0200 Laurent Vivier wrote:

Signed-off-by: Laurent Vivier --- dhcpv6.c | 29 +++++++++++++---------------- dhcpv6.h | 2 +- tap.c | 6 ++---- 3 files changed, 16 insertions(+), 21 deletions(-)

diff --git a/dhcpv6.c b/dhcpv6.c index 365b609addda..d02eb59a08fa 100644 --- a/dhcpv6.c +++ b/dhcpv6.c @@ -535,17 +535,17 @@ static size_t dhcpv6_client_fqdn_fill(const struct iov_tail *data, /** * dhcpv6() - Check if this is a DHCPv6 message, reply as needed * @c: Execution context - * @p: Packet pool, single packet starting from UDP header + * @data Single packet starting from UDP header

Nit: @data:

* @saddr: Source IPv6 address of original message * @daddr: Destination IPv6 address of original message * * Return: 0 if it's not a DHCPv6 message, 1 if handled, -1 on failure */ -int dhcpv6(struct ctx *c, const struct pool *p, +int dhcpv6(struct ctx *c, struct iov_tail *data, const struct in6_addr *saddr, const struct in6_addr *daddr) { const struct opt_server_id *server_id = NULL; - struct iov_tail data, opt, client_id_base; + struct iov_tail opt, client_id_base;

This should be moved one line below. -- Stefano