Re: [PATCH v6 0/8] Add vhost-user support to passt (part 2)

12 Jun 2024

      On Wed, 12 Jun 2024 19:16:17 +0200
Stefano Brivio  wrote:
...
On Wed, 12 Jun 2024 17:47:26 +0200
Laurent Vivier  wrote:
...
Extract buffers management code from tcp.c and move
it to tcp_buf.c
tcp.c keeps all the generic code and will be also used by
the vhost-user functions.
Also compare mode to MODE_PASTA, as we will manage vhost-user
mode (MODE_VU) like MODE_PASST.
Something in this series breaks the pasta_podman/bats test, number 19
in that script (Single TCP port forwarding, IPv4, tap). I'm bisecting
now...
$ git bisect good
3c6a20486425ed00ba5b631bea11135045794dc2 is the first bad commit
commit 3c6a20486425ed00ba5b631bea11135045794dc2
Author: Laurent Vivier 
Date:   Wed Jun 12 17:47:34 2024 +0200

    tap: use in->buf_size rather than sizeof(pkt_buf)

    buf_size is set to sizeof(pkt_buf) by default. And it seems more correct
    to provide the actual size of the buffer.

    Later a buf_size of 0 will allow vhost-user mode to detect
    guest memory buffers.

    Signed-off-by: Laurent Vivier 
    Reviewed-by: David Gibson 
    Signed-off-by: Stefano Brivio 

 tap.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

...checking that patch now.

-- 
Stefano